Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Add the uniques migration for statemine #911

Merged
merged 5 commits into from
Jan 20, 2022
Merged

Conversation

kianenigma
Copy link
Contributor

@kianenigma kianenigma commented Jan 18, 2022

Verified

This commit was signed with the committer’s verified signature.
kianenigma Kian Paimani
@bkchr bkchr added A0-pleasereview B0-silent Changes should not be mentioned in any release notes labels Jan 18, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
need to return the weight from on_runtimie_upgrade().
@kianenigma
Copy link
Contributor Author

Thinking out loud: you might say this is now extra effort that we've created by removing migrations from inside the pallet, but to me this is actually the point: I want more people (perhaps forcefully) thinking about what migrations they need to write, and in which chains they need to be applied, and how to label their PRs so that everyone is notified etc.

@hamidra
Copy link
Contributor

hamidra commented Jan 19, 2022

Thinking out loud: you might say this is now extra effort that we've created by removing migrations from inside the pallet, but to me this is actually the point: I want more people (perhaps forcefully) thinking about what migrations they need to write, and in which chains they need to be applied, and how to label their PRs so that everyone is notified etc.

Also might be worth to update this docs to mention the best practices. I guess many people will start from there when writing migrations!

@kianenigma
Copy link
Contributor Author

Good idea: polkadot-developers/substrate-docs#780

Verified

This commit was signed with the committer’s verified signature.
kianenigma Kian Paimani

Verified

This commit was signed with the committer’s verified signature.
kianenigma Kian Paimani
…umulus into kiz-add-statemine-migration

Verified

This commit was signed with the committer’s verified signature.
kianenigma Kian Paimani
@kianenigma
Copy link
Contributor Author

Should be green now. @bkchr feel free to merge when ready. Note how I updated substrate and polkadot in the commit messages as well.

@bkchr bkchr merged commit f1474d1 into master Jan 20, 2022
@bkchr bkchr deleted the kiz-add-statemine-migration branch January 20, 2022 09:14
@hbulgarini hbulgarini added this to the statemint-v7.0.0 milestone Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Stale on_runtime_upgrade Companion
5 participants