add parachain MultiLocation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidzyyys
suggested changes
Mar 27, 2023
| ); | ||
| } | ||
|
|
||
| function encodeMultiLocationSameConsensusAccountId32( |
There was a problem hiding this comment.
IMHO it should be X1(AccountId32):
Example: /AccountID32(0x234234)
vgeddes
reviewed
Mar 29, 2023
| public pure returns (bytes memory) { | ||
| XCMEnums.XcmV3Junctions interiorJunctions = XCMEnums.XcmV3Junctions.X1; | ||
| XCMEnums.XcmV3Junction firstJunction = XCMEnums.XcmV3Junction.Parachain; | ||
| return abi.encodePacked( |
There was a problem hiding this comment.
Should rather use byte.concat, which was introduced for this purpose. The former abi.encodePacked is discouraged for concatenating bytes.
| BitcoinCore, | ||
| BitcoinCash | ||
| } | ||
| } |
| // SPDX-License-Identifier: Apache-2.0 | ||
| pragma solidity ^0.8.13; | ||
|
|
||
| library XCMEnums { |
There was a problem hiding this comment.
This library is a bit unnecessary. Can define the enums at the toplevel like so:
// SPDX-License-Identifier: Apache-2.0
pragma solidity ^0.8.19;
enum XcmV3Junction {
Parachain,
AccountId32,
AccountIndex64,
AccountKey20,
PalletInstance,
GeneralIndex,
GeneralKey,
OnlyChild,
Plurality,
GlobalConsensus
}
| function encodeU8(uint8 input) internal pure returns (bytes1) { | ||
| return bytes1(input); | ||
| } | ||
| } |
|
|
||
| contract MultiLocationEncoder { | ||
|
|
||
| function encodeMultiLocationSameConsensusParachain( |
There was a problem hiding this comment.
Is a fairly verbose function name. Given that name of the contract suggests multilocation encoding, could condense the name to encodeRelativeParachain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.