Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

chore: update to polkadot-v0.9.40 #25

Merged
merged 3 commits into from
May 20, 2023
Merged

Conversation

evilrobot-01
Copy link
Contributor

@evilrobot-01 evilrobot-01 commented May 17, 2023

Updated to polkadot-v0.9.40 as follows:

polkadot-v0.9.38

Release Impact:

  • XCM v3: xcm_config remains aligned with default from cumulus parachain template, updated as per changes to 0.9.38 in cumulus
  • [Fix] CountedMap::set now takes Counter into account: no usage so not applicable
  • Add Proof Size to Weight Output: pallet-motion uses dispatch info of call to determine weight so auto-updated to support weights V2. Returns Pays::No and has no benchmarking, implying no further action required
  • Scheduler is already at V4: pallet not used directly
  • Fix the storage_size/state_getStorageSize RPC call: not applicable
  • Correct arithmetical semantic of PerDispatchClass: not used directly
  • XCM: Add HRMP to SafeCallFilter: relay chain specific, doesnt seem directly applicable
  • NIS should retain funds in reserve: not used directly
  • [NFTs] Track item’s metadata depositor: not used
  • Enable treasury.spend by Root origin for Polkadot network before Gov2: not applicable
  • Add WeightToFee and LengthToFee impls to transaction-payment Runtime API: implemented based on cumulus template

polkadot-v0.9.39

pallet_collective added SetMembersOrigin to its Config trait. The runtime has been configured to use EnsureRoot<AccountId>.

Release Impact:

  • Referendum proposal’s metadata: neither referenda or democracy pallet used
  • [NFTs] Offchain mint: not applicable
  • Glutton pallet: not applicable but interesting
  • add warp to target block for parachains: service.rs from cumulus parachain template now uses cumulus_client_service::build_network(), which in turn enables parachain warp sync mode based on parachain_config.network.sync_mode. This is effectively set via the --sync warp command line parameter.
  • sc-client-db: Fix PruningMode::ArchiveCanonical: nothing particularly relevant
  • [Feature] Introduce storage_alias for CountedStorageMap: as above, not used
  • try-runtime::fast-forward: command line feature, no additional considerations required
  • Staking and nomination pools runtime API improvements: runtime API only, not currently used
  • Executor Environment parameterization: first step towards execution environment versioning, no further considerations at this time

polkadot-v0.9.40

Uses Weight::from_parts(..) for ExtrinsicBaseWeight and BlockExecutionWeight, both using zero for proof_size.

Release Impact:

  • Introduce XCM matcher for writing barriers: DenyReserveTransferToRelayChain within xcm_config updated to use matcher, based on definition within cumulus parachain template
  • [NFTs] Rework permissions model: not applicable
  • Yieldable queues for pallet MessageQueue: not used
  • Assets pallet: Giving the asset owner the ability to set minimum balance: new dispatchable function added to assets pallet, no additional considerations required
  • Pub enum runtime to pub struct runtime: updated from pub enum Runtime to pub struct Runtime in runtime/lib.rs
  • Nomination Pool Commission: not used directly
  • Salary pallet: not applicable
  • Return account’s asset balances: adds pub fn account_balances(account: T::AccountId) -> Vec<(T::AssetId, T::Balance)> to the assets pallet, which could be exposed via runtime api (example with runtime implementation here). Surprise the API wasnt defined closer to the pallet. Further consideration should be made on whether to include this within the EPT by default
  • Metadata V15: Expose pallet documentation: pallet documentation using the doc and pallet_doc attributes should be added for the motions pallet via a separate issue.

Learnings from paritytech/trappist#171

  • AssetIdForTrustBackedAssets: template has no link to Statemine so no further action required
  • Modified use of Weights: implemented at
    pub UnitWeightCost: Weight = Weight::from_parts(1_000_000_000, 64 * 1024);
    as per cumulus parachain template
  • Contracts Pallet: not applicable
  • Added new fields for XCMv3: same config applied, based on cumulus parachain template. No additional considerations were taken to benchmarking as this is just a template and actually runtimes derived from this template should be benchmarked accordingly.
  • Refactor of Node Service: updated as above
  • UniversalLocation: PR sets to pub UniversalLocation: InteriorMultiLocation = (GlobalConsensus(Network::Rococo),Parachain(ParachainInfo::parachain_id().into(),).into(); which does not seem to apply for a template
  • xcm_config/xcm_executor::Config/SafeCallFilter: set to Everything as per cumulus parachain template, but Trappist sets it to (). Have left as per CPT, figuring that things should work 'out of the box' and leave it to template users to later secure their config before deployment.

@evilrobot-01
Copy link
Contributor Author

Closes #23

@evilrobot-01 evilrobot-01 force-pushed the frank/update_to_polkadot-0.9.40 branch from 80047e9 to c20d552 Compare May 17, 2023 13:19
@evilrobot-01 evilrobot-01 force-pushed the frank/update_to_polkadot-0.9.40 branch from c20d552 to f08554d Compare May 17, 2023 13:22
@evilrobot-01 evilrobot-01 force-pushed the frank/update_to_polkadot-0.9.40 branch from 6ecf46c to f9f63fc Compare May 17, 2023 17:34
@evilrobot-01 evilrobot-01 marked this pull request as ready for review May 19, 2023 09:45
@stiiifff stiiifff requested a review from weezy20 May 19, 2023 09:53
Copy link
Contributor

@weezy20 weezy20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stiiifff stiiifff merged commit 5612968 into main May 20, 2023
@stiiifff stiiifff deleted the frank/update_to_polkadot-0.9.40 branch May 20, 2023 08:18
@stiiifff stiiifff mentioned this pull request Jun 23, 2023
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants