Integrate scale-info for type generation #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
approved these changes
Jan 6, 2021
frame-metadata/src/lib.rs
Outdated
| if #[cfg(feature = "v12")] { | ||
| mod v12; | ||
| pub use v12::*; | ||
| } else if #[cfg(feature = "v13")] { |
There was a problem hiding this comment.
Suggested change
| } else if #[cfg(feature = "v13")] { | |
| } | |
| if #[cfg(feature = "v13")] { |
It should be possible to enable both v12 and `v13
There was a problem hiding this comment.
Right, we will need to reconsider the exports e.g. pub use v12::*; because there will be some duplicates.
Can remove those and just have the user import the v12 v13 types as required?
There was a problem hiding this comment.
Yes, let's avoid the reexports and be explicit about versions.
There was a problem hiding this comment.
Done, please have a look and merge if happy
tomusdrw
approved these changes
Jan 6, 2021
gilescope
referenced
this pull request
in gilescope/frame-metadata
Aug 28, 2022
#2) * Metadata supporting scale-info can be decoded and serialized in no_std (feature flag scale_info) * Changes from review: rename feature flag into full_derive * Changes from review: std implies full-derive * Changes from review: optimization Co-authored-by: echevrier <[email protected]>
jsdw
pushed a commit
that referenced
this pull request
Nov 9, 2022
* Metadata supporting scale-info can be decoded and serialized in no_std (#2) * Metadata supporting scale-info can be decoded and serialized in no_std (feature flag scale_info) * Changes from review: rename feature flag into full_derive * Changes from review: std implies full-derive * Changes from review: optimization Co-authored-by: echevrier <[email protected]> * split full_derive into decode and sered_codec features. (drop new Debug impls) * cargo fmt * rename serde_codec to serde_full * Prior to v14 everything was Debug. Are there any downsides? Unused debug impls will just get optimised away won't they? * rust fmt * Debug for the masses. Make it work for no_std * check all combos of features (if this plays well with ci then we should double up, doing the same again but target wasm32) * all wasm feature combos Co-authored-by: echevrier <[email protected]> Co-authored-by: echevrier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
v13feature which includesscale-infotype information.The
v13metadata is still a work in progress and will likely require some further iteration as I work on the integration process with substrate.