Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metadata versions v8-v11 #28

Merged
merged 17 commits into from
Oct 21, 2021
Merged

Add metadata versions v8-v11 #28

merged 17 commits into from
Oct 21, 2021

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Oct 20, 2021

closes #27

@insipx
Copy link
Contributor Author

insipx commented Oct 20, 2021

Not sure if this is how the versions were envisioned but each metadata version is under a feature flag and then all versions except latest are under 'legacy'

dvdplm
dvdplm approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo nits.

frame-metadata/src/lib.rs Show resolved Hide resolved
frame-metadata/src/v9.rs Show resolved Hide resolved
ascjones
ascjones approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

A "nice to have" would be a single test for each metadata version to verify that it can decode metadata bytes for that version, if they are still lying around anywhere.

TarikGul
TarikGul approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@insipx
Copy link
Contributor Author

insipx commented Oct 21, 2021 •
edited
Loading

@ascjones added some docs & tests. Let me know if they're alright. After that it's good to merge I guess!

I couldn't dig up V8 anywhere, as it turns out Kusama starts with V9

@insipx insipx merged commit b5aceed into main Oct 21, 2021
@insipx insipx deleted the insipx/add-legacy-metadata branch October 21, 2021 13:41
ascjones
ascjones approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Briiliant 👍

@insipx insipx mentioned this pull request Sep 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TarikGul TarikGul TarikGul approved these changes

@ascjones ascjones ascjones approved these changes

@dvdplm dvdplm dvdplm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding Metadata v8-11?
4 participants
@insipx @dvdplm @ascjones @TarikGul