v15: Remove the module_error_ty #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <[email protected]>
jsdw
approved these changes
Jun 15, 2023
niklasad1
approved these changes
Jun 15, 2023
|
Closing this in favor of: #62 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the module error type.
The module error type could be generated by the
construct_runtime!macro in substrate.The
[pallet::error]is included as part of the pallet's definition, however theErrorinformation is not part of the explicit declaration viaSystem: frame_system::{Event<T> ..}, nor the implicit declaration via expansion of pallet parts as inSystem: system.This would require us to change the way we propagate the error, because declaring errors is optional.
Remove the module error for now to stabilize the V15 metadata, leaving room for us to add it in V16 and onwards.
// @paritytech/subxt-team