Adapt to Futures 0.1.15 by not using boxed() #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test that fails on Travis works on my machine on stable Rust. Maybe just restart the build? |
|
Ultimately it would probably be better if there could be less trait objects and more monomorphization. But I didn't feel this was the time to look at that as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Futures 0.1.15 deprecates the
BoxFuturetype and the.boxed()method onFuture. The issue talking about that recommend that people useBox::new(...)instead because it allows the compiler to figure out some magic better. So I went ahead and fixed that.