Remove boxing and allow IntoFuture #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
reviewed
Sep 4, 2017
| /// Asynchronous Method | ||
| pub trait RpcMethodSimple: Send + Sync + 'static { | ||
| /// Output future | ||
| type Out: Future<Item = Value, Error = Error> + Send; |
There was a problem hiding this comment.
why not bound this by IntoFuture also and bump the .into_future call up the chain?
There was a problem hiding this comment.
- Consistency:
RpcMethod:callreturnsFutureas well Sendbound
|
also seems to remove the distinction between sync and async methods as a side effect? either way, super cool! one fewer allocation per RPC call and it opens the door to having |
tomusdrw
force-pushed
the
td-remove-boxfuture
branch
from
8ed751b to
1906651
Compare
tomusdrw
force-pushed
the
td-remove-boxfuture
branch
from
1906651 to
16e612e
Compare
rphmeier
reviewed
Sep 8, 2017
http/src/handler.rs
Outdated
| @@ -46,37 +46,44 @@ impl<M: Metadata, S: Middleware<M>> server::Service for ServerHandler<M, S> { | |||
| type Future = Handler<M, S>; | |||
|
|
|||
| fn call(&self, request: Self::Request) -> Self::Future { | |||
| let action = self.middleware.on_request(&request); | |||
| enum MiddlewareResponse { | |||
There was a problem hiding this comment.
usually, Result is used for cases like this. I recommend a typedef
tomusdrw
force-pushed
the
td-remove-boxfuture
branch
from
625827c to
d4ce60f
Compare
debris
approved these changes
Sep 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntoFuturein many places.RpcMethod)