Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to edition 2021 #1343

Closed
nuke-web3 opened this issue Mar 7, 2022 · 0 comments · Fixed by #1346
Closed

Update to edition 2021 #1343

nuke-web3 opened this issue Mar 7, 2022 · 0 comments · Fixed by #1346

Comments

@nuke-web3
Copy link
Contributor

nuke-web3 commented Mar 7, 2022

using rust stable 1.59.0
cargo fix --edition fails on present master:

 Migrating relays/client-rialto/src/lib.rs from 2018 edition to 2021
    Checking relay-kusama-client v0.1.0 (/home/dan/git/parity-bridges-common/relays/client-kusama)
   Migrating relays/client-kusama/src/lib.rs from 2018 edition to 2021
error[E0391]: cycle detected when computing when `runtime::UtilityCall` has a significant destructor
   --> relays/client-polkadot/src/runtime.rs:146:1
    |
146 | pub enum UtilityCall {
    | ^^^^^^^^^^^^^^^^^^^^
    |
    = note: ...which immediately requires computing when `runtime::UtilityCall` has a significant destructor again
    = note: cycle used when computing whether `relay_substrate_client::chain::SignParam<Polkadot>` has a significant drop

For more information about this error, try `rustc --explain E0391`.
error: could not compile `relay-polkadot-client` due to previous error
warning: build failed, waiting for other jobs to finish...
error[E0391]: cycle detected when computing when `runtime::UtilityCall` has a significant destructor
   --> relays/client-kusama/src/runtime.rs:146:1
    |
146 | pub enum UtilityCall {
    | ^^^^^^^^^^^^^^^^^^^^
    |
    = note: ...which immediately requires computing when `runtime::UtilityCall` has a significant destructor again
    = note: cycle used when computing whether `relay_substrate_client::chain::SignParam<Kusama>` has a significant drop

error: build failed

cargo fix --edition --all-features also fails for unimplimented

Polkadot-primitives v0.9.13 (https://github.com/paritytech/polkadot?branch=master#60df3c55)
error[E0046]: not all trait items implemented, missing: `successful_origin`
    -->......./checkouts/substrate-7e08433d4c370a21/31d90c2/frame/society/src/lib.rs:1268:1
     |
1268 | impl<T: Config> EnsureOrigin<T::Origin> for EnsureFounder<T> {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `successful_origin` in implementation
     |
     = help: implement the missing item: `fn successful_origin() -> OuterOrigin { todo!() }`
svyatonik pushed a commit that referenced this issue Jul 17, 2023
Bumps [parity-scale-codec](https://github.com/paritytech/parity-scale-codec) from 3.1.2 to 3.1.3.
- [Release notes](https://github.com/paritytech/parity-scale-codec/releases)
- [Changelog](https://github.com/paritytech/parity-scale-codec/blob/master/CHANGELOG.md)
- [Commits](paritytech/parity-scale-codec@parity-scale-codec-3.1.2...parity-scale-codec-3.1.3)

---
updated-dependencies:
- dependency-name: parity-scale-codec
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant