-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ChainWithMessages::WeightInfo with correct values according to BridgeHub parachains #1640
Comments
Just an idea for the future: maybe use something like this - https://github.com/ggwpez/substrate-weight-compare - and then just compare on upgrade |
@svyatonik so what do you suggest? How should we fix/change this:
|
Just got an idea when writing an answer - weights are used to compute maximal number of messages and their dispatch weight in delivery transaction. Maybe we should just provide CLI options for "foreign" chains for that? I.e. for Rialto/Millau we'll still have auto-computations and for RBH/WBH we'll have to use cli options like And maybe the best alternative for now is just to choose safe values for those limits and hardcode it somewhere in primitives. E.g. to call My first idea was that we should check/handle it in some way in this runtime-upgrade-helper-tool that we'll have somedeay I hope. |
From Slava PR comment:
The text was updated successfully, but these errors were encountered: