Add RialtoParachain <> Millau bridge to test deployments #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
added
the
A-chores
…vered, then we must select para header that may be proved using this relay header
5 tasks
serban300
reviewed
Aug 4, 2022
| #!/bin/bash | ||
| set -xeu | ||
|
|
||
| sleep 15 |
There was a problem hiding this comment.
Should we also add an initial sleep in the message generation scripts (relay-messages-to-millau-generator-entrypoint.sh for example) ? Otherwise I see that sometimes we get an error when sending the first message. Or is this desired ?
There was a problem hiding this comment.
Do you mean connection errors? That's fine. Actually all these sleeps are now redundant (imo), as the relay is able to wait for required nodes startup itself.
There was a problem hiding this comment.
Yes, connection errors. Ok.
|
Marking the PR as reviewed |
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
…1412) * add RialtoParachain <> Millau bridge to test deployments * flush (still not working, but possible fix in comments) * proper fix * fixed on-demand parachains relay case: if better relay header is delivered, then we must select para header that may be proved using this relay header * dashboards * fmt * removing debugging code * more cleanup
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
…1412) * add RialtoParachain <> Millau bridge to test deployments * flush (still not working, but possible fix in comments) * proper fix * fixed on-demand parachains relay case: if better relay header is delivered, then we must select para header that may be proved using this relay header * dashboards * fmt * removing debugging code * more cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: do not forget to change cli on test deployments when this is merged
closes #1411
WIP. Current issues and TODOs:
9mERROR�[0m �[38;5;8mbridge�[0m Source node (Millau) and pallet at target node (RialtoParachain) have different headers at the same height 0: at-source 0x9f043d430c65dba8fc9b17ac0cad58fe0417360525ec9394880fc6bc3a913c3b54a3fafd81e3e9b38cb98a5fa86fcaecbe777985374e91bfa2e790c3ff2fbd3b vs at-target 0x6269d3d83bc36a0dd77bc74388028280e4254545af3f1c5e243f71f2cc0635b91e67e5226a0ef760fe636a28e410d9060c6992961648daf110d0a4e8f649ce2ain logs (extracted to Different headers at the same height (0) in Millau -> RialtoParachain relay #1421 as non-critical);UPD: first issue seems to disappear after sometime. If everything else will be fixed, it may be extracted in a separate issue
UPD2: the reason of the second issue (log of the Millau node):