Remove message fee + message send calls #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
added
A-chores
svyatonik
commented
Nov 15, 2022
svyatonik
changed the title
svyatonik
commented
Nov 16, 2022
| messages_relayers, | ||
| received_range, | ||
| ); | ||
|
|
||
| register_relayers_rewards::<T>( | ||
| confirmation_relayer, | ||
| relayers_rewards, | ||
| GetConfirmationFee::get(), | ||
| // TODO (https://github.com/paritytech/parity-bridges-common/issues/1318): this shall be fixed |
There was a problem hiding this comment.
Shall be fixed either in this PR, or later
There was a problem hiding this comment.
Left it for later. New relayer rewards scheme will be introduced later && it deserves a separate review
|
Need to test it locally => back to draft |
svyatonik
commented
Nov 17, 2022
|
|
||
| // there's no way to craft XCM of the given size - we'll be using `ExpectPallet` | ||
| // instruction, which has byte vector inside | ||
| let mut current_vec_size = expected_xcm_size; |
There was a problem hiding this comment.
That's the only new code in this PR - since we are now only sending messages using XCM pallet, then the message shall be valid xcm and vec[42; 1024] won't work here.
acatangiu
approved these changes
Nov 18, 2022
bkontur
reviewed
Nov 22, 2022
There was a problem hiding this comment.
@svyatonik
wow, lots of code removed,
very nice, it will also remove lots of my "0/None TODOs" from bridge-hubs :)
4 tasks
jiguantong
pushed a commit
to darwinia-network/darwinia-messages-substrate
that referenced
this pull request
Apr 18, 2023
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
* [WIP][ci] Disable auto-fmt and revert cancel-pipeline * fail test-linux-stable * fix test-linux-stable
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
* remove message fee * it is compiling! * fixes + fmt * more cleanup * more cleanup * restore MessageDeliveryAndDispatchPayment since we'll need relayer rewards * started rational relayer removal * more removal * removed estimate fee subcommand * remove DispatchFeePayment * more removals * removed conversion rates && some metrics * - unneeded associated type * - OutboundMessageFee * fix benchmarks compilation * fmt * test + fix benchmarks * fix send message * clippy
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
* remove message fee * it is compiling! * fixes + fmt * more cleanup * more cleanup * restore MessageDeliveryAndDispatchPayment since we'll need relayer rewards * started rational relayer removal * more removal * removed estimate fee subcommand * remove DispatchFeePayment * more removals * removed conversion rates && some metrics * - unneeded associated type * - OutboundMessageFee * fix benchmarks compilation * fmt * test + fix benchmarks * fix send message * clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves some parts of #1638
very wip => draft
Splitting it into separate issues turned out to be hard - removed parts are tightly tied together, so single PR. I'll explicitly add comments where I'd like to have an approval.
UPD: this PR is not touching everything that is related to relayer rewards
UPD2: what this PR removes:
send_messageandincrease_message_feecalls of the messages pallet + their corresponding benchmarks;estimate-feesubcommand of relayer