Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message delivery transaction is not free!!! #1859

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Message delivery transaction is not free!!! #1859

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3fbea9
message delivery transaction is not free!!!
svyatonik Feb 7, 2023
291486c
test pays_fee
svyatonik Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/messages/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ pub mod pallet {

Self::deposit_event(Event::MessagesReceived(messages_received_status));

Ok(PostDispatchInfo { actual_weight: Some(actual_weight), pays_fee: Pays::No })
Ok(PostDispatchInfo { actual_weight: Some(actual_weight), pays_fee: Pays::Yes })
Copy link
Contributor

@bkontur bkontur Feb 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svyatonik
just thinking, is it worth to have some tests for extrinsics what is free and what not? on pallet level or runtime level?
how would that test look like?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah,, let's add one here. Actually - messages transactions were never intended to be free, so it's just a typo. But in anyway - let's do this

}

/// Receive messages delivery proof from bridged chain.
Expand Down