CLI: Derive Account #860
Merged
CLI: Derive Account #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
HCastano
reviewed
Apr 2, 2021
Comment on lines
72
to
74
| let acc = bp_runtime::SourceAccount::Account(account.raw_id()); | ||
| let id = bp_millau::derive_account_from_rialto_id(acc); | ||
| let derived_account = AccountId::from_raw::<Target>(id); |
There was a problem hiding this comment.
Should't this be part of the macro code? For example, in the case of Millau to Rialto we would want:
let id = bp_rialto::derive_account_from_millau_id(acc);There was a problem hiding this comment.
Great catch, I trusted myself too much that after #849 the code sections are properly split. It didn't trigger any compilation errors, cause the account types are the same on both chains.
HCastano
approved these changes
Apr 5, 2021
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
* Move derive account. * Fix account derivation.
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
* Move derive account. * Fix account derivation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #855
This PR moves
derive-accountsub-command to its own module.