Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Error for FromDecStrErr #346

Merged
merged 2 commits into from
Feb 21, 2020
Merged

Implement Error for FromDecStrErr #346

merged 2 commits into from
Feb 21, 2020

Conversation

e00E
Copy link
Contributor

@e00E e00E commented Feb 21, 2020

No description provided.

@parity-cla-bot
Copy link

It looks like @e00E hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@e00E
Copy link
Contributor Author

e00E commented Feb 21, 2020

[clabot:check]

@parity-cla-bot
Copy link

It looks like @e00E signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@@ -38,6 +38,21 @@ pub enum FromDecStrErr {
InvalidLength,
}

impl std::fmt::Display for FromDecStrErr {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the CI failure is legit, we should hide this (and the one below) impl under cfg(feature = std)

macro_rules! impl_std_for_uint {

@ordian ordian merged commit 05d7da8 into paritytech:master Feb 21, 2020
ordian added a commit that referenced this pull request Mar 2, 2020
* master:
  kvdb-rocksdb: bump version (#348)
  kvdb-rocksdb: expose RocksDB stats (#347)
  Implement Error for FromDecStrErr (#346)
  Fix clippy lints for rlp-derive (#345)
ordian added a commit that referenced this pull request Mar 6, 2020
* master:
  kvdb-rocksdb: bump version (#348)
  kvdb-rocksdb: expose RocksDB stats (#347)
  Implement Error for FromDecStrErr (#346)
  Fix clippy lints for rlp-derive (#345)
  prepare rlp-derive release (#344)
  Update/change licenses: MIT/Apache2.0 (#342)
  rlp-derive extracted (#343)
  Format for readme and changelog corrected (#341)
  Parity runtime moved to parity common for publication in crates.io (#271)
  Disable cache if explicit memory budget=0 passed (#339)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants