-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Error for FromDecStrErr #346
Conversation
It looks like @e00E hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io Once you've signed, please reply to this thread with Many thanks, Parity Technologies CLA Bot |
[clabot:check] |
It looks like @e00E signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
@@ -38,6 +38,21 @@ pub enum FromDecStrErr { | |||
InvalidLength, | |||
} | |||
|
|||
impl std::fmt::Display for FromDecStrErr { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the CI failure is legit, we should hide this (and the one below) impl under cfg(feature = std)
parity-common/uint/src/uint.rs
Line 1546 in 46d8f6b
macro_rules! impl_std_for_uint { |
* master: kvdb-rocksdb: bump version (#348) kvdb-rocksdb: expose RocksDB stats (#347) Implement Error for FromDecStrErr (#346) Fix clippy lints for rlp-derive (#345) prepare rlp-derive release (#344) Update/change licenses: MIT/Apache2.0 (#342) rlp-derive extracted (#343) Format for readme and changelog corrected (#341) Parity runtime moved to parity common for publication in crates.io (#271) Disable cache if explicit memory budget=0 passed (#339)
No description provided.