This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Key files include timestamp in name. #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce timestamp into new key files; keep filename around, so that we don't accidentally duplicate keys.
| fn insert(&self, account: SafeAccount) -> Result<(), Error> { | ||
| self.dir.insert(account) | ||
| fn insert(&self, account: SafeAccount) -> Result<SafeAccount, Error> { | ||
| self.dir.insert(account.clone()) |
| @@ -15,6 +15,8 @@ rustc-serialize = "0.3" | |||
| rust-crypto = "0.2.36" | |||
| tiny-keccak = "1.0" | |||
| docopt = { version = "0.6", optional = true } | |||
| time = "0.1.34" | |||
| log = "0.3" | |||
There was a problem hiding this comment.
Is this used? I cant't see any logging added
arkpar
added
A5-grumble 🔥
gavofyork
added
A0-pleasereview 🤓
…y into timestamp-in-key-filenames
arkpar
added
A8-looksgood 🦄
| @@ -35,16 +36,17 @@ pub struct SafeAccount { | |||
| pub version: Version, | |||
| pub address: Address, | |||
| pub crypto: Crypto, | |||
| pub path: Option<PathBuf>, | |||
There was a problem hiding this comment.
What do you think about just storing a filename: Option<String> instead? It will allow migrations between two DiskDirectories - right know accounts with path.is_some() can basically come from anywhere on the disk and whole DiskDirectory is kind of useless and misleading.
There was a problem hiding this comment.
a potential improvement, sure, but not strictly necessary for this feature.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce timestamp into new key files; keep filename around, so
that we don't accidentally duplicate keys.