Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Add Kovan WASM activation blocknumber #8057

Merged
merged 1 commit into from
Mar 12, 2018
Merged

Conversation

NikVolf
Copy link
Contributor

@NikVolf NikVolf commented Mar 5, 2018

closes #7292

*** REQUIRES 7970 ***

@NikVolf NikVolf added A0-pleasereview 🤓 Pull request needs code review. B0-patch M4-core ⛓ Core client code / Rust. labels Mar 5, 2018
@5chdn 5chdn added the P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. label Mar 5, 2018
@@ -40,7 +40,8 @@
"eip140Transition": 5067000,
"eip211Transition": 5067000,
"eip214Transition": 5067000,
"eip658Transition": 5067000
"eip658Transition": 5067000,
"wasmActivationTransition": 6500000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we fork on Friday? 6262000?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, release will not be ready before Wed, we need at least 1 day for binaries and 1 day for tests

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's fork on next Wed then?

Copy link
Contributor

@andresilva andresilva Mar 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6350000? Although at this point it's safer to push it to Friday.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, 6500000 is safer
we add might have some integration tests (in dedicated repos) meanwhile

@tomusdrw tomusdrw mentioned this pull request Mar 7, 2018
@debris debris merged commit 06fa900 into master Mar 12, 2018
@debris debris deleted the kovan-wasm-block-number branch March 12, 2018 09:55
@5chdn 5chdn added this to the 1.11 milestone Mar 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue of wasm support in Kovan
5 participants