-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow justifications on non-finalized blocks #1159
Comments
CC @arkpar |
No objections from my side. |
Okay perfect :) @andresilva is on holidays. @nazar-pc let's create a pr :) |
This was referenced Aug 25, 2023
bkchr
added a commit
that referenced
this issue
Sep 12, 2023
One assertion was unnecessary because of the check right above it, second assertion resolves #1159 --------- Co-authored-by: Bastian Köcher <[email protected]>
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this issue
Mar 25, 2024
One assertion was unnecessary because of the check right above it, second assertion resolves paritytech#1159 --------- Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently Substrate enforces that blocks must not have justifications unless they are finalized:
polkadot-sdk/substrate/client/service/src/client/client.rs
Line 606 in 1a38d6d
It is useful, however, for other purposes as well, for instance I would like to use justifications to make nodes send extra data alongside blocks that are not strictly required, but do help with block verification.
Grandpa already has a check that finalized blocks must have justifications (with redundant assertion afterwards) if I understand it correctly, so should not be an issue to remove this requirement (I think):
polkadot-sdk/substrate/client/consensus/grandpa/src/import.rs
Lines 548 to 555 in 1a38d6d
Any concerns if I send a PR removing this restriction?
The text was updated successfully, but these errors were encountered: