max_extrinsic in BlockWeight limit per class should take into account base_block
#329
Labels
T1-FRAME
This PR/Issue is related to core FRAME, the framework.
Comments
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
|
still sensible to me |
the-right-joyce
added
T1-FRAME
claravanstaden
pushed a commit
to Snowfork/polkadot-sdk
that referenced
this issue
Dec 8, 2023
* Limit number of messages in commitment queues * Set commitment queue limit to 20, try_mutate -> decode_len + append
helin6
pushed a commit
to boolnetwork/polkadot-sdk
that referenced
this issue
Feb 5, 2024
* Correct load transactions by hash * Make rustc happy
jonathanudd
pushed a commit
to jonathanudd/polkadot-sdk
that referenced
this issue
Apr 10, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
when computing what is the maximal weight for an extrinsic of a given class we have to manually substract the base_block weight.
https://github.com/paritytech/substrate/blob/fcf950ca4906bed0b8118d6b40fa8a8a0acf9425/bin/node/runtime/src/lib.rs#L512-L515
Instead
max_extrinsicshould take into account that the weight consume bybase_blockis not available:https://github.com/paritytech/substrate/blob/fcf950ca4906bed0b8118d6b40fa8a8a0acf9425/frame/system/src/limits.rs#L406-L416
The text was updated successfully, but these errors were encountered: