Cleanup String::from_utf8 usage in the pallet benchmarking

[ggwpez]

👉 Good issue for newcomers (please dont pick up when you already have experience).

The state machine that is used in the benchmark pallet command returns a [u8] instead of a string.
This slice is then stored and converted to a string every time its needed somewhere.
It would be nice to instead directly convert it and then store the string. This would get rid of a many String::from_utf8(…).expect("Encoded from String; qed").

[sudipghimire533]

I can take on this guys if you are ok with it @ggwpez

[ggwpez]

Yes thats good, thanks @sudipghimire533

[sudipghimire533]

@ggwpez Looks like I am not sure which part are we referring. Can you please mention a example where the change should be brought. Thank you :)

[ggwpez]

You can start by searching for String::from_utf8 in the utils/frame/benchmarking-cli folder.
Once you see where its used, you can start to put it into a String variable so that the from_utf8 can be removed, should be easy.

[sudipghimire533]

Ahh ok PR 11908 took longer than expected. I'll try if I can give time. Thanks anyway :)

[philoniare]

@ggwpez can I take this on?

[ggwpez]

Yes! Note that we cannot entirely use String, since it get passed through the WASM-Host barrier and that only allows Vec<u8> so it can only be converted after being in the std code.

[philoniare]

Yes! Note that we cannot entirely use String, since it get passed through the WASM-Host barrier and that only allows Vec<u8> so it can only be converted after being in the std code.

Got it, appreciate the tip, will keep it in mind