Disable try state payees check from pallet-staking temporarily
#3259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpestana
added
R0-silent
ggwpez
approved these changes
Feb 8, 2024
| #[test] | ||
| #[should_panic = "called `Result::unwrap()` on an `Err` value: Other(\"number of entries in payee storage items does not match the number of bonded ledgers\")"] | ||
| //#[should_panic = "called `Result::unwrap()` on an `Err` value: Other(\"number of entries in payee | ||
| //#[should_panic storage items does not match the number of bonded ledgers\")"] | ||
| fn check_payee_invariant1_works() { |
There was a problem hiding this comment.
I think you can also add something like #[cfg(feature = "unused")] but its not a big difference.
|
Actually this disables it on all networks. Maybe just comment the CI check instead. I asked in chat now. |
liamaharon
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Westend try-state checks are currently failing and blocking the CI. This PR will unblock the CI until the issue is sorted out.
Related to #3245. These changes should be reverted once the issue is fixed.