benchmarking-cli: add --list-pallets and --all options #3395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Consistent collection attribute namespace * System attribute collection level * Update comments * Revert nonfungible_v2 changes * More reverts * Add tests * Extract collection_id in tests * Fix import * Add `list-pallets` and `all` flags
dastansam
changed the title
|
Usage looks fine, will give a closer look tomorrow 👍 |
ggwpez
reviewed
Feb 20, 2024
ggwpez
reviewed
Feb 20, 2024
|
hey @ggwpez, comments are resolved. Not sure about the also, because of |
bkchr
approved these changes
Feb 21, 2024
Co-authored-by: Bastian Köcher <[email protected]>
ggwpez
reviewed
Feb 21, 2024
ggwpez
reviewed
Feb 21, 2024
ggwpez
approved these changes
Feb 21, 2024
ggwpez
added
the
T12-benchmarks
|
It still needs a prdoc, then we can merge 😄 |
added |
ggwpez
reviewed
Feb 21, 2024
ggwpez
reviewed
Feb 21, 2024
Merged
via the queue into
paritytech:master
with commit Feb 21, 2024
165d075
126 of 129 checks passed
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
closes paritytech#2844 - adds `list-pallets` option which prints all unique available pallets for benchmarking ```bash ./target/release/node benchmark pallet --list=pallets ``` - adds `all` option which runs benchmarks for all available pallets and extrinsics (equivalent to `--pallet * --extrinsic *`) ```bash ./target/release/node benchmark pallet --all ``` - use the `list=pallets` syntax in `run_all_benchmarks.sh` script cc ggwpez --------- Co-authored-by: Bastian Köcher <[email protected]>
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2844
list-palletsoption which prints all unique available pallets for benchmarkingalloption which runs benchmarks for all available pallets and extrinsics (equivalent to--pallet * --extrinsic *)list=palletssyntax inrun_all_benchmarks.shscriptcc ggwpez