chainHead: Stabilize chainHead to version 1 #4168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <[email protected]>
lexnv
added
A1-insubstantial
Signed-off-by: Alexandru Vasile <[email protected]>
lexnv
changed the title
jsdw
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
I'm happy with this!
I wonder whether, in this initial PR, we should alias eg chainHead_unstable_foo to call chainHead_v1_foo, just so that clients like PAPI/Subxt will continue to work until they update. I'm not personally too fussed from Subxt's PoV though. - Since PAPI uses Smoldot anyway it probably doesn't care, and I don't care for Subxt so I think we can just change them to v1 without any extra effort.
niklasad1
approved these changes
Apr 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
The CI pipeline was cancelled due to failure one of the required jobs. |
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stabilizes the chainHead API to version 1.
Needs:
cc @paritytech/subxt-team