Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pallet_balances: Add try_state for checking Holds and Freezes #4490

Merged
merged 3 commits into from
May 17, 2024
Merged

pallet_balances: Add try_state for checking Holds and Freezes #4490

merged 3 commits into from
May 17, 2024

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented May 16, 2024

No description provided.

@bkchr bkchr added R0-silent Changes should not be mentioned in any release notes T1-FRAME This PR/Issue is related to core FRAME, the framework. labels May 16, 2024
@bkchr bkchr requested a review from a team as a code owner May 16, 2024 20:39
@bkontur
Copy link
Contributor

bkontur commented May 17, 2024

nice, thank you :), this was also one of my TODOs here: #2997

@bkchr
Copy link
Member Author

bkchr commented May 17, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented May 17, 2024 •
edited
Loading

@bkchr https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6230628 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-32be0582-7699-4fd2-be5b-6b3c0bc01483 to cancel this command or bot cancel to cancel all commands in this pull request.

@bkchr
Copy link
Member Author

bkchr commented May 17, 2024

nice, thank you :), this was also one of my TODOs here: #2997

Ahh nice, didn't see this! :D I had this idea yesterday, because of this discussion on this pr from last year.

@bkchr bkchr enabled auto-merge May 17, 2024 08:09
@command-bot
Copy link

command-bot bot commented May 17, 2024

@bkchr Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6230628 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6230628/artifacts/download.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6230645

@bkchr bkchr added this pull request to the merge queue May 17, 2024
Merged via the queue into master with commit ca0fb0d May 17, 2024
147 of 149 checks passed
@bkchr bkchr deleted the bkchr-balances-try-state branch May 17, 2024 11:59
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
@bkchr @hitchhooker
pallet_balances: Add try_state for checking Holds and Freezes (p…
f56208c 
…aritytech#4490)

Co-authored-by: command-bot <>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@bkchr @TarekkMA
pallet_balances: Add try_state for checking Holds and Freezes (p…
121753a 
…aritytech#4490)

Co-authored-by: command-bot <>
This was referenced Aug 21, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamaharon liamaharon liamaharon approved these changes

@ggwpez ggwpez ggwpez approved these changes

@bkontur bkontur bkontur approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bkchr @bkontur @paritytech-cicd-pr @ggwpez @liamaharon