rpc: add prometheus metrics for dropped subscriptions #4835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
changed the title
niklasad1
force-pushed
the
na-jsonrpsee-v0.23-with-ip-addr
branch
from
44979f7 to
c7be842
Compare
niklasad1
commented
Jun 21, 2024
niklasad1
commented
Jun 21, 2024
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4184
This PR adds
prometheus metricsthat keeps track of the number of subscriptions and which peer that caused that.This is useful for rpc node operators to know how many subscriptions are dropped and which peers that are causing that i.e, to take action to ban certain peers that are just creating lots of subscriptions and don't read them fast-enough...
Builds on #4730