Multi-Block-Migrations: Support small steps #4989
Open
+445
−203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
pgherveou
reviewed
Jul 24, 2024
substrate/frame/examples/multi-block-migrations/src/migrations/v1/mod.rs
Show resolved
Hide resolved
substrate/frame/examples/multi-block-migrations/src/migrations/v1/mod.rs
Show resolved
Hide resolved
Comment on lines
755
to
759
| Self::deposit_event(Event::MigrationAdvanced { | ||
| index: cursor.index, | ||
| took_blocks, | ||
| took_steps, | ||
| }); |
There was a problem hiding this comment.
should we keep that event? I am just thinking that it's going to be a lot of deposited event (1 for each iteration)
There was a problem hiding this comment.
Yes i also wondered it. Maybe only at the end of the loop... will try how it looks.
Emitting one event per iteration could be problematic when a migration does thousands of steps per block, and hardly that useful. We therefore only emit one MigrationAdvanced event at the end of the block. Signed-off-by: Oliver Tale-Yazdi <[email protected]>
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-Block-Migrations currently require the migrations to do as much compute per step as possible.
This was done to allow for more efficient batch code to run, but from a user perspective it can be much nicer to be able to do just a tiny step (eg migrating a map key).
This MR changes MBM to be able to do mini steps, but stays backwards compatible to MBMs that do big steps.
Changes:
Integration
You can now optionally implement this function for your MBMs:
impl SteppedMigration for MyMigration { ... + fn max_steps() -> Option<u32> { + None + } }Not implementing it is defaulting to no limit - same as before.