allow use of slot based collator in parachain template #5007
Conversation
| Adds an `--experimental-use-slot-based` CLI parameter to the default parachain template, | ||
| which enables the slot based collator. |
There was a problem hiding this comment.
Must also mention that it should only be used to enable elastic scaling on the client.
| /// | ||
| /// Use with care, this flag is unstable and subject to change. | ||
| #[arg(long)] | ||
| pub experimental_use_slot_based: bool, |
There was a problem hiding this comment.
The slot based collator is just an implementation detail, which is likely not going to be of interest to node operators, they would only care to enable the elastic scaling.
So, why not just --elastic-scaling ? In the future slot based collator will be used for everything, but for the time being this is only the only way to enable elastic scaling.
There was a problem hiding this comment.
I mean this is in the end only for people who want to test the bleeding edge. The CLI flag will vanish at some point.
If we go with elastic scaling we should at least keep --experimental-elastic-scaling.
| /// | ||
| /// Use with care, this flag is unstable and subject to change. | ||
| #[arg(long)] | ||
| pub experimental_use_slot_based: bool, |
There was a problem hiding this comment.
I mean this is in the end only for people who want to test the bleeding edge. The CLI flag will vanish at some point.
If we go with elastic scaling we should at least keep --experimental-elastic-scaling.
|
Yeah, we don't want this in the template. This is highly experimental. The guide can just reference |
This will make it possible to use docify for #4663