-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bridge zombienet tests: remove old command #5434
Merged
acatangiu
merged 2 commits into
paritytech:master
from
serban300:bridge-zombienet-small-fixes
Aug 28, 2024
Merged
Bridge zombienet tests: remove old command #5434
acatangiu
merged 2 commits into
paritytech:master
from
serban300:bridge-zombienet-small-fixes
Aug 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serban300
added
T10-tests
This PR/Issue is related to tests.
T15-bridges
This PR/Issue is related to bridges.
labels
Aug 21, 2024
serban300
added
the
R0-silent
Changes should not be mentioned in any release notes
label
Aug 21, 2024
Hi @serban300, could be check if we can migrate those test to use the new sdk? |
Hi @pepoviola ! In the long run probably we'll want to migrate them to the new SDK, but it's a matter of prioritization. Right now we don't have the bandwidth to do it and probably it's a low priority issue. |
acatangiu
approved these changes
Aug 21, 2024
bkchr
approved these changes
Aug 28, 2024
Merged
via the queue into
paritytech:master
with commit Aug 28, 2024
edd6f71
248 of 253 checks passed
ordian
added a commit
that referenced
this pull request
Aug 29, 2024
* master: (39 commits) short-term fix for para inherent weight overestimation (#5082) CI: Add backporting bot (#4795) Fix benchmark failures when using `insecure_zero_ed` flag (#5354) Command bot GHA v2 - /cmd <cmd> (#5457) Remove pallet::getter usage from treasury (#4962) Bump blake2b_simd from 1.0.1 to 1.0.2 (#5404) Bump rustversion from 1.0.14 to 1.0.17 (#5405) Bridge zombienet tests: remove old command (#5434) polkadot-parachain: Add omni-node variant with u64 block number (#5269) Refactor verbose test (#5506) Use umbrella crate for minimal template (#5155) IBP Coretime Polkadot bootnodes (#5499) rpc server: listen to `ipv6 socket` if available and `--experimental-rpc-endpoint` CLI option (#4792) Update approval-voting-regression-bench (#5504) change try-runtime rpc domains (#5443) polkadot-parachain-bin: Remove contracts parachain (#5471) Add feature to allow Aura collator to use full PoV size (#5393) Adding stkd bootnodes (#5470) Make `PendingConfigs` storage item public (#5467) frame-omni-bencher maintenance (#5466) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
R0-silent
Changes should not be mentioned in any release notes
T10-tests
This PR/Issue is related to tests.
T15-bridges
This PR/Issue is related to bridges.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #3176
This PR:
This test didn't work before and it still doesn't work. It was added at a time when we couldn't run it because we didn't have the scafolding. It needs to be fixed. For the moment we keep it in the repo as it is since the idea has value. But we don't run it in the CI. We can also decide to remove it in the future