Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edge case where state sync is not triggered #5635

Merged
merged 6 commits into from
Sep 10, 2024
Merged

Fix edge case where state sync is not triggered #5635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a58bf78
Extract `attempt_state_sync()`
liuchengxu Sep 7, 2024
3672c34
Add `pending_state_sync_attempt`
liuchengxu Sep 7, 2024
4f03545
Add prdoc
liuchengxu Sep 7, 2024
6d5cd14
Update substrate/client/network/sync/src/strategy/chain_sync.rs
liuchengxu Sep 9, 2024
207463e
Merge branch 'master' into fix-state-sync-lost
bkchr Sep 10, 2024
03f6e42
FMT
liuchengxu Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions prdoc/pr_5635.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
title: Fix edge case where state sync is not triggered

doc:
- audience: Node Dev
description: |
There is an edge case where the finalized block notification is received, but the conditions required to initiate the
state sync are not fully met. In such cases, state sync would fail to start as expected and remain stalled.
This patch addresses it by storing the pending attempt and trying to start the state sync later when the conditions
are satisfied.

crates:
- name: sc-network-sync
bump: patch
Loading