Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add offchain_localStorageClear RPC method #7266

Merged
merged 10 commits into from
Jan 23, 2025

Conversation

khssnv
Copy link
Contributor

@khssnv khssnv commented Jan 20, 2025

Description

Closes #7265.

Integration

Requires changes in https://github.com/polkadot-js/api/packages/{rpc-augment,types-support,types} to be visible in Polkadot\Substrate Portal and in other libraries where we should explicitly state RPC methods.

Accompany PR to polkadot-js/api: polkadot-js/api#6070.

Review Notes

Please put the right label on my PR.

@bkchr bkchr added the T0-node This PR/Issue is related to the topic “node”. label Jan 20, 2025
@bkchr bkchr requested a review from a team January 20, 2025 20:27
@bkchr
Copy link
Member

bkchr commented Jan 20, 2025

/cmd prdoc --bump minor --audience node_operator

@bkchr bkchr enabled auto-merge January 20, 2025 20:30
@github-actions github-actions bot requested a review from bkchr January 21, 2025 05:03
Copy link
Contributor

Review required! Latest push from author must always be reviewed

prdoc/pr_7266.prdoc Show resolved Hide resolved
@skunert skunert disabled auto-merge January 21, 2025 17:06
prdoc/pr_7266.prdoc Outdated Show resolved Hide resolved
@bkchr
Copy link
Member

bkchr commented Jan 21, 2025

@khssnv can you please fix the tests?

@github-actions github-actions bot requested review from bkchr and skunert January 22, 2025 18:15
@khssnv
Copy link
Contributor Author

khssnv commented Jan 22, 2025

Sure, thanks for the review, tests fixed, sorry, I didn't see them fail locally with cargo test.

@skunert skunert enabled auto-merge January 23, 2025 09:46
@bkchr
Copy link
Member

bkchr commented Jan 23, 2025

/cmd fmt

Copy link
Contributor

Command "fmt" has started 🚀 See logs here

Copy link
Contributor

Command "fmt" has finished ✅ See logs here

@skunert skunert added this pull request to the merge queue Jan 23, 2025
auto-merge was automatically disabled January 23, 2025 11:27

Pull Request is not mergeable

Merged via the queue into paritytech:master with commit 66bd26d Jan 23, 2025
196 of 204 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing RPC method offchain_localStorageClear
3 participants