Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check-publish-compile job #7306

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix check-publish-compile job #7306

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f019de
Fix 6689 prdoc
skunert Jan 23, 2025
f332a16
Try with published bandersnatch_vrfs
ggwpez Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion prdoc/pr_6689.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ doc:
- audience: Runtime Dev
description: |-
Update the current approach to attach the `ref_time`, `pov` and `deposit` parameters to an Ethereum transaction.
Previously, these three parameters were passed along with the signed payload, and the fees resulting from gas × gas_price were checked to ensure they matched the actual fees paid by the user for the extrinsic
Previously, these three parameters were passed along with the signed payload, and the fees resulting from gas × gas_price were checked to ensure they matched the actual fees paid by the user for the extrinsic

This approach unfortunately can be attacked. A malicious actor could force such a transaction to fail by injecting low values for some of these extra parameters as they are not part of the signed payload.

Expand Down
Loading