Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

PVF validation host doesn't work well with Docker #3044

Closed
pepyakin opened this issue May 17, 2021 · 0 comments · Fixed by #3057
Closed

PVF validation host doesn't work well with Docker #3044

pepyakin opened this issue May 17, 2021 · 0 comments · Fixed by #3057
Labels
I3-bug Fails to follow expected behavior.
Milestone

Comments

@pepyakin
Copy link
Contributor

PVF validation host owns a cache of compiled artifacts. This cache is populated by preparation workers, sub-processes that perform some checks and compile the artifact.

Specifically, a preparation worker first creates a file in the temporary directory. Once compiled and wrote, the artifact is moved into its final location. We do this so that because other parts of

The move is performed with async_std::fs::rename which, similarly to std::fs::rename, relies on rename(2).

From std::fs::rename:

This will not work if the new name is on a different mount point.

Almost always /tmp has a different mount point than the node's basedir. My tests and test run on Rococo showed it worked well. I assume this is related to some special handling of tmpfs. Regardless, there was a report of this not working on Docker. It manifested in empty files copied into the artifact caches.

@pepyakin pepyakin added the I3-bug Fails to follow expected behavior. label May 17, 2021
@pepyakin pepyakin added this to the Van Ness milestone May 17, 2021
pepyakin added a commit that referenced this issue May 19, 2021
bkchr added a commit that referenced this issue May 21, 2021
* Put WIP artifacts next to ready ones

Fixes #3044

* Apply suggestions from code review

Co-authored-by: Bastian Köcher <[email protected]>

Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I3-bug Fails to follow expected behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant