Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Introduce a NetworkBridgeEvent::UpdatedAuthorityIds #6192

Closed
rphmeier opened this issue Oct 26, 2022 · 3 comments · Fixed by #6227
Closed

Introduce a NetworkBridgeEvent::UpdatedAuthorityIds #6192

rphmeier opened this issue Oct 26, 2022 · 3 comments · Fixed by #6227
Labels
I8-refactor Code needs refactoring. T4-parachains_engineering This PR/Issue is related to Parachains performance, stability, maintenance.

Comments

@rphmeier
Copy link
Contributor

rphmeier commented Oct 26, 2022

The current network logic doesn't handle the ability for peers to update their authority IDs (i.e. key rotation) very well. The network bridge should be continually updating its known authority IDs for each peer ID and informing subsystems of any changes so they can adapt accordingly.

@rphmeier rphmeier added I8-refactor Code needs refactoring. Q2-easy labels Oct 26, 2022
@rphmeier rphmeier changed the title Introduce a NetworkBridgeEvent::NewAuthorityIds Introduce a NetworkBridgeEvent::UpdatedAuthorityIds Oct 26, 2022
@eskimor eskimor moved this to To do in Parachains-core Oct 27, 2022
@eskimor eskimor added T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes. T4-parachains_engineering This PR/Issue is related to Parachains performance, stability, maintenance. and removed T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes. labels Oct 27, 2022
@Szegoo
Copy link
Contributor

Szegoo commented Nov 1, 2022

@rphmeier I will attempt this issue.

@bkchr
Copy link
Member

bkchr commented Nov 10, 2022

BTW, it can also happen the other way around, the peerid for an authorityid changes. Both sides can change and peerid can also change much more often than the authorityid.

@ordian
Copy link
Member

ordian commented Nov 10, 2022

BTW, it can also happen the other way around, the peerid for an authorityid changes

That would imply that the node with an old PeerId will disconnect and with the new one connect. We already track AuthorityId changes on connection/disconnection.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I8-refactor Code needs refactoring. T4-parachains_engineering This PR/Issue is related to Parachains performance, stability, maintenance.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants