Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to Peer ID from session topology #762

Open
rphmeier opened this issue Oct 26, 2022 · 1 comment
Open

Remove references to Peer ID from session topology #762

rphmeier opened this issue Oct 26, 2022 · 1 comment
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. I4-refactor Code needs refactoring.

Comments

@rphmeier
Copy link
Contributor

This is related to paritytech/polkadot#6192 . Given that the session topology is computed at the beginning of the session or when the node starts up, the peer IDs corresponding to each validator index may be out of date after a short time. The session topology should not store explicit references to Peer ID, and it should be the responsibility of networking subsystem to determine the correct Peer ID for any given validator based on the authority IDs it has learned about connected peers.

Some reusable utility code for tracking session authority ID -> connected peer mappings would be useful.
@rphmeier
Copy link
Contributor Author

rphmeier commented Oct 26, 2022 •
edited
Loading

At the point where the gossip topology is no longer implicitly related to authority discovery, it would make sense for the gossip support subsystem to directly send the topology to subsystems as opposed to via the network bridge. In fact, it could be that we should migrate the gossip support subsystem to a request/response mechanism where subsystems request the topology when they need it. This would eliminate a class of race conditions.

@mrcnski mrcnski mentioned this issue Jan 28, 2023
Closed
@eskimor eskimor mentioned this issue Jan 5, 2023
Open
@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
@the-right-joyce the-right-joyce added I4-refactor Code needs refactoring. C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. T8-parachains_engineering and removed I8-refactor labels Aug 25, 2023
claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
@doubledup
Remove incentivized channel and apps (paritytech#762)
345c63d 
* Remove apps & incentivized channel from parachain (paritytech#753)

* Remove apps & incentivized channel from parachain

* Fix formatting

* Remove incentivized channel & channel ID from relayer (paritytech#756)

* Remove incentivized channel from relayer

Will regenerate the bindings in contracts/ in the Solidity PR.

Still TODO:
- Remove mapping in:
    - relayer/cmd/fetch_messages.go
    - relayer/relays/ethereum/ethereum-listener.go
- Remove redundant imports of github.com/ethereum/go-ethereum/core/types
- Remove channel ID in relayer/relays/parachain/query_events.go
- Remove other occurrences of channelId:
rg -i channelid | sed -r 's/([^:]*):.*/\1/' | uniq | rg -v ^contracts/
- Replace Events with BasicChannelEvent in
  relayer/relays/parachain/query_events.go
- Remove unused relays/parachain/storage_key.go

* Remove address-method mapping for basic channel

* Remove redundant import

* Remove unused module storage_key

* Remove channelID

* Replace Events struct with BasicChannelEvent

* Remove incentivized channel, apps, channel ID & sundry from contracts (paritytech#757)

* Remove incentivized channel

* Remove deprecated prettier option

Deprecated in prettier-plugin-solidity 1.0.0:
NomicFoundation/hardhat-vscode#367 (comment)

The comment above indicates that solhint might have a rule for this, but
it doesn't look like there is one yet:
https://protofire.github.io/solhint/

* Remove apps

* Remove channel id

* Remove unused OpaqueProof

* Regenerate contract bindings

* Replace necessary contracts

* Fix generated contract bindings

Remove incentivized channel bindings & keep generating OpaqueProof.

* Move log & mining settings to Hardhat config

* Remove other references to apps & custom token

* Remove incentivized channel and apps from test & cleanup  (paritytech#759)

* Remove app and incentivized channel from tests

This also removes all existing tests, since they all depend on the apps.

* Remove channelID

* Remove some remaining references

Still need to decide on the docs/ and core/packages/api/ directories.

* Remove asset-registry pallet

Not removing the assets pallet yet, as it's still used by the XCM
pallet.

* Reorder params to match other runtimes

Makes diffs between the runtimes cleaner.

* Remove detect-fork script

* Remove helper code in src/

* Keep src/ directory

* Convert MessageId to struct
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
@nanocryk
fix wrong error convertion (paritytech#762)
87baadf
bkchr pushed a commit that referenced this issue Apr 10, 2024
@tomusdrw @adoerr @bkchr
Add inspect command to take a look at extrinsics. (#762)
c3d651d 
* Add inspect command to take a look at extrinsics.

* cargo fmt --all

* New weight for on-chain remark in tests

* Minor style tweaks.

Co-authored-by: adoerr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. I4-refactor Code needs refactoring.
Projects
parachains team board
Status: Backlog
Parachains-core
Status: To do
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eskimor @mrcnski @rphmeier @the-right-joyce