This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Switch to Wasmtime for parachain execution #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-please_review
bkchr
approved these changes
Jan 14, 2021
|
One change is still required. We need to add a wasmtime feature to Line 43 in 2fd345b (And the code would also need to check for this feature) |
|
@bkchr I have made that change |
bkchr
approved these changes
Jan 15, 2021
|
bot merge |
|
Waiting for commit status. |
|
Merge failed: |
xlc
pushed a commit
to xlc/polkadot
that referenced
this pull request
Jan 26, 2021
* Switch to Wasmtime for parachain execution * Fix the signature for halt's validate_block * wasmtime feature enabled from cli * Adds missing feature Co-authored-by: Sergei Shulepov <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.