This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix bug in statement table #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only checked all validity votes, ignoring invalid votes. So, the condidition could not hold. Besides fixing the panic, I removed some old cruft that isn't required anymore.
bkchr
added
A0-please_review
bkchr
commented
Feb 3, 2021
| ValidityVote::Issued(ref s) => | ||
| Some((a, ValidityAttestation::Implicit(s.clone()))), | ||
| }) | ||
| .take(validity_threshold) |
There was a problem hiding this comment.
If someone comes up with a good explanation why we only want to have validity_threshold votes forwarded, please tell it. Otherwise, I don't see any reason to restrict this.
rphmeier
approved these changes
Feb 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only checked all validity votes, ignoring invalid votes. So, the
condidition could not hold. Besides fixing the panic, I removed some old
cruft that isn't required anymore.
Fixes: #2368