Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

End multiplexer stream once one of its inputs end. #2380

Merged
2 commits merged into from
Feb 4, 2021
Merged

End multiplexer stream once one of its inputs end. #2380

2 commits merged into from
Feb 4, 2021

Conversation

eskimor
Copy link
Member

@eskimor eskimor commented Feb 4, 2021

Also add test, that we don't panic once a stream is exhausted.

@eskimor
End multiplexer stream once one of its inputs end.
9b75ed8 
Also add test, that we don't panic once a stream is exhausted.
@eskimor eskimor added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes labels Feb 4, 2021
@eskimor eskimor requested review from drahnr and ordian February 4, 2021 10:23
@ordian ordian added the C1-low PR touches the given topic and has a low impact on builders. label Feb 4, 2021
@ordian
Copy link
Member

ordian commented Feb 4, 2021

An alternative would be what @drahnr suggested, it seems even simpler:
#2352 (comment)

@eskimor
Copy link
Member Author

eskimor commented Feb 4, 2021 •
edited
Loading

An alternative would be what @drahnr suggested, it seems even simpler:
#2352 (comment)

Actually yes, don't know why I picked the harder way. shrug

@eskimor eskimor added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). and removed A0-please_review Pull request needs code review. labels Feb 4, 2021
@eskimor
Copy link
Member Author

eskimor commented Feb 4, 2021

Ok strictly speaking this PR alters logic, but it is small only touches new code, got reviewed and fixes a panic - so quick merge should be fine.

@eskimor
Copy link
Member Author

eskimor commented Feb 4, 2021

bot merge

@ghost
Copy link

ghost commented Feb 4, 2021

Trying merge.

@ghost ghost merged commit d165deb into master Feb 4, 2021
@ghost ghost deleted the rk-fix-panic branch February 4, 2021 11:31
ordian added a commit that referenced this pull request Feb 4, 2021
@ordian
merge master
b1268aa 
* master:
  Unused variable can be ignored (#2381)
  End multiplexer stream once one of its inputs end. (#2380)
  Cargo build step needs pre requisites not mentioned (#2379)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

@drahnr drahnr Awaiting requested review from drahnr

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eskimor @ordian