-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
git-subtree-dir: bridges git-subtree-split: 345e84a
"bridges/primitives/kusama", | ||
"bridges/primitives/polkadot", | ||
"bridges/primitives/runtime", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reminds me - we have a branch called bridges-integration
which already adds some Polkadot and Kusama primitives. While it's a bit outdated (last commit was Dec 22nd), we should probably use it as a reference for integration moving forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll add integration in a separate PR cause it should be properly reviewed. This one is 65k lines of code that was already reviewed in bridges repo, hence the separation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really have any strong opinions on this, I haven't done any research on it anyway so I just trust your judgment. Either way, I think this is the way to go in the sense that we should just test this approach and if it doesn't work we can revert it later, otherwise there will be opinions floating around with nothing getting decided in practice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What @andresilva says
This PR adds entire https://github.com/paritytech/parity-bridges-common repository as git subtree.
The goal of having Bridges code in Polkadot repo is to make it possible to integrate with polkadot-based runtimes (Rococo & Westend first, later Polkadot & Kusama), while achieving following properties:
I expect this integration will have a bunch of bumps on it's way, but it's still the best what we get to satisfy above conditions. I know this is something we have never really tried before and the PR is quite significant, despite that I feel it's worth to try.
How to work with
git subtree
?Some FAQ
Why git subtree?
crates.io
versioning - not feasibly for now, given our fast development pace.git submodule
- this may lead to including unreviewed (neither in Polkadot nor in Bridges) code (just referencing commit hash of bridges repo) and may be hard to track versioning-wise (i.e. "Does this hash contain that important change or is it done on some other fork of the code").git subtree
- the code is duplicated in both repos, there might be some unused/unreferenced code lingering in Polkadot repo.Why not remove unused bridges files?
What about BEEFY / other projects
Why not integrate BRIDGES with Substrate repo?