-
Notifications
You must be signed in to change notification settings - Fork 1.6k
technical committee is using the weight of council, but should have its own generated weight instead #3511
Conversation
/benchmark polkadot pallet pallet_collective_council |
Error running benchmark: gui-fix-weights-collective stdoutNode benchmarks only available on Substrate. |
/benchmark runtime polkadot pallet_collective_council |
Benchmark Runtime Polkadot Pallet for branch "gui-fix-weights-collective" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_collective_council --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/ Results
|
…gui-fix-weights-collective
/benchmark runtime polkadot pallet_collective_council |
Benchmark Runtime Polkadot Pallet for branch "gui-fix-weights-collective" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_collective_council --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/ Results
|
/benchmark runtime polkadot pallet_collective |
Benchmark Runtime Polkadot Pallet for branch "gui-fix-weights-collective" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_collective --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/ Results
|
…k --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_collective --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/
/benchmark runtime kusama pallet_collective |
Benchmark Runtime Kusama Pallet for branch "gui-fix-weights-collective" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_collective --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/ Results
|
…k --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_collective --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/
/benchmark runtime polkadot pallet_collective_council |
Benchmark Runtime Polkadot Pallet for branch "gui-fix-weights-collective" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_collective_council --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/ Results
|
/benchmark runtime kusama pallet_collective |
Benchmark Runtime Kusama Pallet for branch "gui-fix-weights-collective" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_collective --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/ Results
|
…k --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_collective --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/
the bot generates an implementation of the trait which is incomplete, I need to look into it |
/benchmark runtime polkadot pallet_collective |
Benchmark Runtime Polkadot Pallet for branch "gui-fix-weights-collective" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_collective --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/ Results
|
/benchmark runtime polkadot pallet_collective |
Benchmark Runtime Polkadot Pallet for branch "gui-fix-weights-collective" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_collective --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/ Results
|
/benchmark runtime polkadot pallet_collective |
Benchmark Runtime Polkadot Pallet for branch "gui-fix-weights-collective" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_collective --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/ Results
|
a297ef2
to
3670dde
Compare
/benchmark runtime polkadot pallet_collective |
Benchmark Runtime Polkadot Pallet for branch "gui-fix-weights-collective" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_collective --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/ Results
|
…gui-fix-weights-collective
/benchmark runtime kusama pallet_collective |
Benchmark Runtime Kusama Pallet for branch "gui-fix-weights-collective" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_collective --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/ Results
|
…k --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_collective --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/
…k --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_collective --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/
this should be now good to go |
thanks for figuring out the issues with the pipeline |
bot merge |
Error: When trying to meet the "Project Owners" approval requirements: this pull request does not belong to a project defined in Process.json. Approval by "Project Owners" is only attempted if other means defined in the criteria for merge are not satisfied first. The following errors might have affected the outcome of this attempt:
|
bot merge |
Trying merge. |
* master: dependabot: ignore yet another git dep (#3759) Bump serde_json from 1.0.66 to 1.0.67 (#3767) Bump syn from 1.0.74 to 1.0.75 (#3710) Companion for substrate #9371 (#3487) Fixes/improvements for disputes (#3753) chore: test helper arbitrary ordering for 2 (#3762) disputes: fix relay chain selection sanity check (#3750) technical committee is using the weight of council, but should have its own generated weight instead (#3511) new proxy for auctions, crowdloans, registrar, slots (#3683) Bump libc from 0.2.100 to 0.2.101 (#3726) Removed unneeded deps (#3658) Bump serde from 1.0.127 to 1.0.130 (#3739) Companion for Generate storage info for pallet authority_discovery #9428 (#3517) Return a Result in invert_location (#3730) XCM: Allow reclaim of assets dropped from holding (#3727)
currently technical committee is using the weight of council, but should have its own generated weight instead
when I read https://substrate.dev/rustdocs/latest/frame_benchmarking/macro.add_benchmark.html I see that in case of instances the path is the concatenation of both pallet path and pallet name
cc @shawntabrizi
TODO
Rerun benchmarks: