This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Parachains para_inherent.rs to FrameV2 #3531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferrell-code
commented
Jul 29, 2021
Comment on lines
+1155
to
1158
| // circumvent requirement to have bitfields and headers in block for testing purposes | ||
| crate::paras_inherent::Included::<Test>::set(Some(())); | ||
|
|
||
| AllPallets::on_finalize(b); |
There was a problem hiding this comment.
The addition of ParaInherent in the mock construct_runtime! causes the ParaInherent on_finalize hook to now fire in disputes test and will panic as no inherents have been entered. I believe this to be reasonable for the disputes tests but figured I would explain as it is not that obvious
There was a problem hiding this comment.
looks fine to me cc @rphmeier
shawntabrizi
added
A0-please_review
shawntabrizi
approved these changes
Jul 31, 2021
KiChjang
approved these changes
Aug 3, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates: #2882
Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.
From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines
So users of the
ParaInherentpallet must be careful about the name they used inconstruct_runtime!.Hence the runtime-migration label, which might not be needed depending on the configuration of theParaInherentpallet.kusama, rococo and westend use
ParasInherentinconstruct_runtime!, so I migrated them toParaInherentpolkadot does not use
ParaInherent.