This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
ignore irrelevant approvals in logs #3859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A2-insubstantial
ordian
approved these changes
Oct 3, 2021
ordian
added a commit
that referenced
this pull request
Oct 3, 2021
* master: (72 commits) change genesis authority set for wococo-local, revert rococo-local (#3998) ignore irrelevant approvals in logs (#3859) avoid expect, on free availability core (#3994) preserve finalized block in active leaves (#3997) some tweaks to rococo-local (#3996) always broadcast tranche 0 assignments and add a delay before approval (#3904) Tidy up XCM errors in preparation for v2. (#3988) add disputes call to Rococo (#3993) Fix an off-by-one: revert rather than revert-to (#3991) add logs to relay chain selection (#3990) av-store: clean up StoreAvailableData message (#3984) add polkadot-simnet runner (#3985) Remove incorrect proof about Jemalloc (#3982) add new rococo chainspec (#3976) bump async-std's version to remove conflict for substrate (#3981) gossip-support: set last_session_index earlier (#3978) Companion for substrate PR#9890 (#3961) Bump version, tx_version and spec_version in prep for v0.9.11 (#3970) Fix master compilation (#3977) Make most XCM APIs accept an Into<MultiLocation> where MultiLocation is accepted (#3627) ...
ordian
added a commit
to Lldenaurois/polkadot
that referenced
this pull request
Oct 3, 2021
* master: Remove unoccupied bit check (paritytech#3999) bump substrate (paritytech#4000) change genesis authority set for wococo-local, revert rococo-local (paritytech#3998) ignore irrelevant approvals in logs (paritytech#3859) avoid expect, on free availability core (paritytech#3994)
ordian
added a commit
that referenced
this pull request
Oct 5, 2021
* master: (138 commits) Allow an Offset to Lease Periods (#3980) Bump quote from 1.0.9 to 1.0.10 (#4013) Companion for #9834 (Transaction Priority) (#3901) chore: update `builder` image (#3884) Free disputed cores before processing bitfields (#4008) Make candidate validation timeouts configurable (#4001) Add extrinsic ordering filtering (#3631) chore: ci list files that spellcheck finds (#3992) Use background tasks properly in candidate-validation (#4002) Fix unoccupied bitfields (#4004) Bump syn from 1.0.77 to 1.0.78 (#4006) Bump jsonrpsee-ws-client from 0.3.0 to 0.3.1 (#3931) fix clock drift for assignments issued before the block (#3851) Remove unoccupied bit check (#3999) bump substrate (#4000) change genesis authority set for wococo-local, revert rococo-local (#3998) ignore irrelevant approvals in logs (#3859) avoid expect, on free availability core (#3994) preserve finalized block in active leaves (#3997) some tweaks to rococo-local (#3996) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logging about unapproved (candidate, block) pairs would count approvals for (candidate, another_block) pairs, meaning that we'd encounter bizarre situations like
Which indicates that there are 12 assignments and 19 approvals. In fact, there were only 11 approvals for the specific block hash mentioned.