-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add benchmarking to rococo; Remove weights from runtime_parachains #3914
Conversation
/benchmark runtime custom --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtime/rococo/src/weights/runtime_parachains_paras.rs --header=./file_header.txt |
Benchmark Runtime Custom for branch "zeke-add-rococo-weights" with command cargo run --quiet --release --features runtime-benchmarks -- benchmark --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtime/rococo/src/weights/runtime_parachains_paras.rs --header=./file_header.txt Results
|
…zeke-add-rococo-weights
…k --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtime/rococo/src/weights/runtime_parachains_paras.rs --header=./file_header.txt
…ch/polkadot into zeke-add-rococo-weights
/benchmark runtime custom --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::configuration --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtime/rococo/src/weights/runtime_parachains_configuration.rs --header=./file_header.txt |
Benchmark Runtime Custom for branch "zeke-add-rococo-weights" with command cargo run --quiet --release --features runtime-benchmarks -- benchmark --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::configuration --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtime/rococo/src/weights/runtime_parachains_configuration.rs --header=./file_header.txt Results
|
…k --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::configuration --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtime/rococo/src/weights/runtime_parachains_configuration.rs --header=./file_header.txt
// Storage: Paras CurrentCodeHash (r:1 w:1) | ||
// Storage: Paras CodeByHashRefs (r:1 w:1) | ||
// Storage: Paras PastCodeMeta (r:1 w:1) | ||
// Storage: Paras PastCodePruning (r:1 w:1) | ||
// Storage: Paras PastCodeHash (r:0 w:1) | ||
// Storage: Paras CodeByHash (r:0 w:1) | ||
fn force_set_current_code(c: u32, ) -> Weight { | ||
(14_669_000 as Weight) | ||
(0 as Weight) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whats up here
// Standard Error: 0 | ||
.saturating_add((3_000 as Weight).saturating_mul(c as Weight)) | ||
.saturating_add(T::DbWeight::get().reads(4 as Weight)) | ||
.saturating_add(T::DbWeight::get().writes(6 as Weight)) | ||
} | ||
// Storage: Paras Heads (r:0 w:1) | ||
fn force_set_current_head(s: u32, ) -> Weight { | ||
(0 as Weight) | ||
(14_890_000 as Weight) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or here
@@ -65,7 +74,7 @@ impl<T: frame_system::Config> super::WeightInfo for WeightInfo<T> { | |||
// Storage: Paras FutureCodeHash (r:0 w:1) | |||
// Storage: Paras UpgradeRestrictionSignal (r:0 w:1) | |||
fn force_schedule_code_upgrade(c: u32, ) -> Weight { | |||
(37_383_000 as Weight) | |||
(0 as Weight) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a particularly big change
/benchmark runtime custom --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtime/rococo/src/weights/runtime_parachains_paras.rs --header=./file_header.txt |
Benchmark Runtime Custom for branch "zeke-add-rococo-weights" with command cargo run --quiet --release --features runtime-benchmarks -- benchmark --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtime/rococo/src/weights/runtime_parachains_paras.rs --header=./file_header.txt Results
|
…zeke-add-rococo-weights
…k --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtime/rococo/src/weights/runtime_parachains_paras.rs --header=./file_header.txt
I don't see file removals for |
/benchmark runtime custom --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtime/rococo/src/weights/runtime_parachains_paras.rs --header=./file_header.txt |
Benchmark Runtime Custom for branch "zeke-add-rococo-weights" with command cargo run --quiet --release --features runtime-benchmarks -- benchmark --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtime/rococo/src/weights/runtime_parachains_paras.rs --header=./file_header.txt Results
|
…k --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtime/rococo/src/weights/runtime_parachains_paras.rs --header=./file_header.txt
bot merge |
Waiting for commit status. |
Merge aborted: Checks failed for 174cb8a |
f413ff5
to
c00e371
Compare
bot merge |
Waiting for commit status. |
This PR adds benchmarking to the rococo runtime and removes weights from polkadot-runtime-parachains. @shawntabrizi advised that we don't want weights within polkadot-runtime-parachains because the weights are not universally applicable.
Only code for benchmarking the modules within polkadot-runtime-parachains was added to Rococo since those weights are no longer available from a dependency.