This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update wasmtime config to match new version in substrate #4063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
reviewed
Oct 12, 2021
@@ -65,6 +68,7 @@ const CONFIG: Config = Config { | |||
native_stack_max: 256 * 1024 * 1024, | |||
}), | |||
canonicalize_nans: true, | |||
parallel_compilation: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we want single-threaded compilation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only want to turn it on when performing PVF prechecking, it can be introduced here (pass different semantics):
sc_executor_wasmtime::prepare_runtime_artifact(blob, &CONFIG.semantics) |
Otherwise, the multithreaded behavior remains
pepyakin
approved these changes
Oct 12, 2021
Waiting for commit status. |
ordian
added
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
labels
Oct 12, 2021
ghost
deleted the
slumber-update-substrate-wasmtime
branch
October 12, 2021 15:56
ordian
added a commit
that referenced
this pull request
Oct 14, 2021
* master: (40 commits) use pipeline-scripts for dependent projects script (#4017) companion for substrate/10013 (#4078) fix restart issue of staking miner (#4073) use `WEIGHT_PER_SECOND` (#4077) Switch to compressed runtimes (#4061) Create a README for XCMv1 detailing notable changes (#4058) Bump proc-macro2 from 1.0.29 to 1.0.30 (#4071) Move runtime to with_transaction in order to Rollback state changes (#4067) Update wasmtime config to match new version in substrate (#4063) Fix XCM Weights on Westend (#4066) Dispatchable XCMs should translate to v0 (#4062) Add xcm fuzzer (#3869) Bump trybuild from 1.0.49 to 1.0.50 (#4060) Companion PR for ss58 crate (#3953) overseer: simplify debugging some more (#4053) Bump thiserror from 1.0.29 to 1.0.30 (#4048) Bump strum from 0.21.0 to 0.22.0 (#4047) Add para pallets to polkadot benchmarks (#4045) Fixes broken docker link in docker descriptiob (#4043) Bump trybuild from 1.0.48 to 1.0.49 (#4039) ...
emostov
pushed a commit
that referenced
this pull request
Nov 1, 2021
* Update wasmtime config to match new version * update Substrate Co-authored-by: parity-processbot <>
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.