Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix fast-runtime #5025

Merged
merged 3 commits into from
Mar 3, 2022
Merged

Conversation

zjb0807
Copy link
Contributor

@zjb0807 zjb0807 commented Mar 3, 2022

There have prod_or_fast and fast-runtime feature, so revert #2167

@bkchr
Copy link
Member

bkchr commented Mar 3, 2022

I don't see any reason why this should be done. This changes the behavior in quite some way.

@zjb0807
Copy link
Contributor Author

zjb0807 commented Mar 3, 2022

I don't see any reason why this should be done. This changes the behavior in quite some way.

pub const DEFAULT_EPOCH_DURATION: BlockNumber = prod_or_fast!(1 * HOURS, 1 * MINUTES);
frame_support::parameter_types! {
pub storage EpochDurationInBlocks: BlockNumber = DEFAULT_EPOCH_DURATION;
}

prod_or_fast was used here, but the EpochDurationInBlocks was modified in chain_spec.rs. It's going to be a little confusing

@zjb0807
Copy link
Contributor Author

zjb0807 commented Mar 3, 2022

I need a stable rococo-local network to test para chain, EPOCH_DURATION is 1min and will cause UnexpectedEpochChange.

@bkchr
Copy link
Member

bkchr commented Mar 3, 2022

I need a stable rococo-local network to test para chain, EPOCH_DURATION is 1min and will cause UnexpectedEpochChange.

I never had problems with 1 minute epochs. However, your change here would also just lead to 1 minute epochs when you use fast. You clearly don't want to wait 1 hour until your Parachain is onboarded. With the current code, you can also change the epoch/session length in the chain spec.

@zjb0807 zjb0807 changed the title Fix rococo EpochDuration Fix fast-runtime Mar 3, 2022
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 3, 2022
@bkchr
Copy link
Member

bkchr commented Mar 3, 2022

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 8964c53 into paritytech:master Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants