Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

rococo: update weights #5242

Merged
merged 1 commit into from
Apr 6, 2022
Merged

rococo: update weights #5242

merged 1 commit into from
Apr 6, 2022

Conversation

coderobe
Copy link
Contributor

@coderobe coderobe commented Apr 3, 2022

this is a full run of the rococo weights benchmarks using the same process we use for the other runtimes.
this covers the benchmarks mentioned in paritytech/polkadot-sdk#850

@coderobe coderobe added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Apr 3, 2022
@coderobe coderobe requested review from brunopgalvao and ggwpez April 3, 2022 08:21
@coderobe
Copy link
Contributor Author

coderobe commented Apr 3, 2022

the full benchmark log is available at https://gitlab.parity.io/parity/polkadot/-/jobs/1475199/raw

@coderobe
Copy link
Contributor Author

coderobe commented Apr 3, 2022

Benchmark failure(s):

2022-04-03 05:12:32 Running Benchmark: runtime_parachains::paras_inherent.enter_bitfields 1/50 1/1    
2022-04-03 05:12:32 Took active validators from set with wrong size    
2022-04-03 05:12:32 Took active validators from set with wrong size.    
2022-04-03 05:12:32 Took active validators from set with wrong size    
2022-04-03 05:12:32 Took active validators from set with wrong size    
2022-04-03 05:12:32 Took active validators from set with wrong size.    
2022-04-03 05:12:32 Took active validators from set with wrong size    
2022-04-03 05:12:32 Took active validators from set with wrong size    
2022-04-03 05:12:32 Took active validators from set with wrong size.    
2022-04-03 05:12:32 Took active validators from set with wrong size    
2022-04-03 05:12:32 panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `101`', /home/gitlab-runner/builds/G3WgZWf2/0/parity/polkadot/runtime/parachains/src/paras_inherent/benchmarking.rs:119:9    
Error: 
   0: �[91mInvalid input: Error executing and verifying runtime benchmark: Execution aborted due to trap: wasm trap: wasm `unreachable` instruction executed
      WASM backtrace:

          0: 0x67a5 - <unknown>!rust_begin_unwind
          1: 0x2f6a - <unknown>!core::panicking::panic_fmt::h8f11323637b4db3b
          2: 0x703e - <unknown>!core::panicking::assert_failed_inner::hb7fa033f7ee539c7
          3: 0x4410e - <unknown>!core::panicking::assert_failed::hf837eae46cefa84c
          4: 0x2fc664 - <unknown>!<rococo_runtime::Runtime as frame_benchmarking::utils::runtime_decl_for_Benchmark::Benchmark<sp_runtime::generic::block::Block<sp_runtime::generic::header::Header<u32,sp_runtime::traits::BlakeTwo256>,sp_runtime::generic::unchecked_extrinsic::UncheckedExtrinsic<sp_runtime::multiaddress::MultiAddress<<<sp_runtime::MultiSignature as sp_runtime::traits::Verify>::Signer as sp_runtime::traits::IdentifyAccount>::AccountId,()>,rococo_runtime::Call,sp_runtime::MultiSignature,(frame_system::extensions::check_non_zero_sender::CheckNonZeroSender<rococo_runtime::Runtime>,frame_system::extensions::check_spec_version::CheckSpecVersion<rococo_runtime::Runtime>,frame_system::extensions::check_tx_version::CheckTxVersion<rococo_runtime::Runtime>,frame_system::extensions::check_genesis::CheckGenesis<rococo_runtime::Runtime>,frame_system::extensions::check_mortality::CheckMortality<rococo_runtime::Runtime>,frame_system::extensions::check_nonce::CheckNonce<rococo_runtime::Runtime>,frame_system::extensions::check_weight::CheckWeight<rococo_runtime::Runtime>,pallet_transaction_payment::ChargeTransactionPayment<rococo_runtime::Runtime>)>>>>::dispatch_benchmark::hbc0648726bb7873a
          5: 0x395cfe - <unknown>!Benchmark_dispatch_benchmark
   0: �[0m

Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.

/cc @brunopgalvao @shawntabrizi

@brunopgalvao
Copy link
Contributor

Looks like we have to uncomment this line for Rococo.

@coderobe
Copy link
Contributor Author

coderobe commented Apr 3, 2022

that's not too great

@ggwpez
Copy link
Member

ggwpez commented Apr 4, 2022

Okay I will take a look, thanks @coderobe.
As for the failing one: This should be the last failing benchmark across all benchmarks and runtimes.
So we can probably already merge the weights if they are sane and then fix the last one.

@coderobe coderobe merged commit 60f4525 into master Apr 6, 2022
@coderobe coderobe deleted the coderobe/weights-rococo branch April 6, 2022 08:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants