This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Collator connection management #5388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this more precise information, we can also trigger an early announcement of a collation. (Not yet implemented)
github-actions
bot
added
the
A3-in_progress
- Basic connection management logic, at least data wise. - "Prepared" for async backing already
rphmeier
reviewed
Apr 27, 2022
| /// | ||
| /// The values of this map are the group/session combinations we want to be connected for the | ||
| /// given block height. | ||
| required_connections: HashMap<BlockNumber, HashSet<(SessionIndex, GroupIndex)>>, |
rphmeier
reviewed
Apr 27, 2022
| /// | ||
| /// The values of this map are the group/session combinations we want to be connected for the | ||
| /// given block height. | ||
| required_connections: HashMap<BlockNumber, HashSet<(SessionIndex, GroupIndex)>>, |
There was a problem hiding this comment.
could this be a BTreeMap? might make pruning easier (prune all up to X)
There was a problem hiding this comment.
I was thinking about that, but for the time it looks like it is not needed.
rphmeier
reviewed
Apr 27, 2022
| // | ||
| // - insert message | ||
| // - send to all already connected peers if in view. | ||
| // -> View still relevant with async backing? Likely only when it comes to height. |
There was a problem hiding this comment.
View is still relevant - view determines their 'implicit view', which is the view-head + some ancestry (described in more detail here: #5054 (comment))
bkchr
reviewed
May 12, 2022
| /// If the above is not possible, but a collator is aware it's going to produce a candidate | ||
| /// based **on relay parent**, should also return `true`. | ||
| /// 1. Collators who can't know in advance whether they are going to have a collation, shall | ||
| /// return `None` on every call. |
There was a problem hiding this comment.
Why not have something like CollationForecast::Uknown? Then we don't need the option?
There was a problem hiding this comment.
I think, I just liked the explicit separation between supporting collators and those which don't. Anyhow, flattening might indeed be the better option.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still WIP
Goals:
AdvertiseCollationmessages, so we can do that round trip while preparing the collation already.cumulus companion: paritytech/cumulus#1255