Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Substrate companion #11387 #5531

Merged
merged 5 commits into from
May 17, 2022
Merged

Substrate companion #11387 #5531

merged 5 commits into from
May 17, 2022

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented May 16, 2022

@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 16, 2022
@bkchr bkchr requested review from KiChjang and kianenigma May 16, 2022 10:37
@bkchr bkchr mentioned this pull request May 16, 2022
Merged
KiChjang
KiChjang reviewed May 17, 2022
View reviewed changes
runtime/common/src/crowdloan/migration.rs Outdated
type NextTrieIndex<T: Config> = StorageValue<Pallet<T>, FundIndex>;

#[storage_alias]
type Leases<T: Config> = StorageMap<Pallet<T>, Twox64Concat, ParaId, Vec<Option<(<T as frame_system::Config>::AccountId, BalanceOf<T>)>>>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the prefix for this correct? Previously it had Slots, but this one now has Pallet<T>, which I assume is the one for Crowdloan?

Copy link
Member Author

@bkchr bkchr May 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh! Good find!

bkchr
bkchr commented May 17, 2022
View reviewed changes
runtime/common/src/crowdloan/migration.rs Outdated
type NextTrieIndex<T: Config> = StorageValue<Pallet<T>, FundIndex>;

#[storage_alias]
type Leases<T: Config> = StorageMap<Pallet<T>, Twox64Concat, ParaId, Vec<Option<(<T as frame_system::Config>::AccountId, BalanceOf<T>)>>>;
Copy link
Member Author

@bkchr bkchr May 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh! Good find!

runtime/common/src/crowdloan/migration.rs Outdated Show resolved Hide resolved
@shawntabrizi
Copy link
Member

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 1a445d9 into master May 17, 2022
@paritytech-processbot paritytech-processbot bot deleted the bkchr-storage-alias-proc-macro branch May 17, 2022 23:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kianenigma kianenigma kianenigma approved these changes

@KiChjang KiChjang KiChjang approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bkchr @shawntabrizi @KiChjang @kianenigma