This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Bump MAX_CODE_SIZE to 10MiB
#7105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
added
A0-please_review
|
The CI pipeline was cancelled due to failure one of the required jobs. |
12 tasks
|
Good find! The actual solution is that we should decrease the max code size on chain. By accident @eskimor and me spoke about the max code size on Tuesday. This value should not be bigger than the max block size of Polkadot, as otherwise we will not be able to build blocks which would try to add a parachain upgrade that is 10MiB big. |
|
Opened an issue: #7108 |
|
So, I would close this pr. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Polkadot HostConfiguration does not pass its
consistency_checksince it is using 10MiB max code size and the hard-limit is set to 3MiB. I dont know how that happened, but I am now bumpingMAX_CODE_SIZEto make the consistency check pass again.Note: without this bump the
consistency_checkwill stay broken, since it has the assumption: "You cannot break something that is already broken" and thereby future HostConfig upgrades would not get checked.MIN_BANDWIDTH_BYTESwill probably also need a bump.