-
Notifications
You must be signed in to change notification settings - Fork 1.6k
RollingSessionWindow
cleanup
#7204
Changes from 39 commits
5eb24c6
b0da049
93e6863
a7b74cc
0f84b42
0e486d4
f6a9d98
2918b42
837f952
6f609f3
82a0ebc
dca7287
360b96d
caa2529
7665ecd
3f2b85c
19e9588
70d136f
6e348c9
4fa4403
dc0542a
233478e
d27220a
407eb27
2ed7dfd
dcac680
96ffefe
81acb35
14eb540
0606eee
6a2a9e2
0f94664
db120f6
0ffd17f
7d83f95
b938b92
39ae191
84c134a
c7439c5
2f6b33b
0ccfe2c
ab7197d
40daf94
44fe75a
bbbd5ee
4b45afb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should this be moved to v2? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't understand this. What is the relation between the versioning here and the one in
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the versioning in approval-voting and dispute-coordinator are there to distinguish in-memory types and types found in the db so we can detect the type mismatches and fix them at compile time. Each of those represent a subset of parachains_db, so if only dispute-coordinator changes only, approval-voting remains on the same version. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I completely forgot about this one. Any objections to move the code in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No objection from me. @eskimor ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well everything written to db needs to be versioned. If for now we only have one version, we should at least document that this can not be simply changed, but requires a db migration. Having the versioning already in place, seems like a good approach to me, to be honest. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That makes sense. A breaking change in the way I've added a comment describing why the two version differ. This was confusing for me initially. I'm not bumping to v2 though as there are no changes required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
I'm not bumping the version but I'll add a clarification what
v1
means.