Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Disable spellcheck CI job #7512

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Conversation

rcny
Copy link
Contributor

@rcny rcny commented Jul 18, 2023

The mentioned test fails for a quite some time and introduces unnecessary misunderstandings. Disabling.

@rcny rcny added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jul 18, 2023
@rcny rcny requested a review from bkchr July 18, 2023 18:25
@rcny rcny self-assigned this Jul 18, 2023
@rcny rcny requested review from a team and chevdor as code owners July 18, 2023 18:25
@paritytech-ci paritytech-ci requested a review from a team July 18, 2023 18:25
@franciscoaguirre
Copy link
Contributor

I had to whitelist some words in #7077 because the CI job took into account files not in the diff. Now it needs approvals from CI.

If we disabled or fixed the job it'd be better.

Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also allow failure - but it should be easy to fix. Thanks!

@ggwpez
Copy link
Member

ggwpez commented Jul 18, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit b97654d into master Jul 18, 2023
@paritytech-processbot paritytech-processbot bot deleted the vi/ci-disable-spellcheck branch July 18, 2023 19:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants